Thor

Results 36 comments of Thor

> Error: `sync/atomic` is in the blacklist: Use go.uber.org/atomic instead of sync/atomic (depguard) Looks like its necessary to update the `.golangci.yml` file

``` Error: copylocks: NewPartList passes lock by value: sync/atomic.Pointer[github.com/polarsignals/frostdb.Node] contains sync/atomic.noCopy (govet) Error: copylocks: literal copies lock value from next: sync/atomic.Pointer[github.com/polarsignals/frostdb.Node] contains sync/atomic.noCopy (govet) Error: copylocks: call of NewPartList copies...

Closing in favor of https://github.com/polarsignals/frostdb/pull/203 thanks for the contribution @Mihai22125

I'm going to close this, since the query engine has change dramatically since opening we'll need a different approach for averages. Thanks!

> > I think overall I'm fine with this change, my only question is if we considered instead of doing a sweep, we do a notify? Where after adding to...

Yes! This is definitely something we want to add. Thanks for opening up an issue about it as it's definitely something we need to track.

https://pprof.me/96f41cb Can see that the most of memory is being utilized by `splitRowsByGranule` and not by the actual storage blocks.

![image](https://user-images.githubusercontent.com/8681572/186022959-b6661095-37c1-4b17-8133-37c7d1efc744.png) We get a little over 6GiB before the block is rotated and memory usage drops

https://github.com/polarsignals/frostdb/pull/189 should fix the high memory usage

Closing this issue as https://github.com/parca-dev/parca/pull/1682 has merged.