frostdb icon indicating copy to clipboard operation
frostdb copied to clipboard

Support average aggregation

Open yeya24 opened this issue 2 years ago • 2 comments

Signed-off-by: Ben Ye [email protected]

One thing I am not sure about is how to deal with the float64 type array in the tests.

yeya24 avatar Sep 09 '22 17:09 yeya24

Thanks for starting with this feature. Since we've introduced the new possibility to have concurrent physical plans we need to split the calculation of averages into multiple steps. We need to calculate the count and sum of the value that should be average transparently and only at the very last aggregation step run sum / count.

Now, we can merge it as is, but that would make the introduction of the concurrent physical plan be blocked on this feature until we refactored it to be concurrent. How critical is it for you to get the average into FrostDB right now?

metalmatze avatar Sep 13 '22 09:09 metalmatze

Thanks @metalmatze. This feature is not urgent. I can calculate the average on the application side as well.

yeya24 avatar Sep 13 '22 16:09 yeya24

I'm going to close this, since the query engine has change dramatically since opening we'll need a different approach for averages.

Thanks!

thorfour avatar Nov 03 '22 15:11 thorfour