Thom Seddon

Results 109 comments of Thom Seddon

Thanks for the PR! I see the tests pass, unfortunately there seem to be a few shortcuts in there right now :) I'd love to upgrade the mongo version but...

Hmm, the code is actually pretty simple: https://github.com/thomseddon/co-mongo/blob/master/lib/collection.js#L59-L69 Would you mind having a look at it?

Would be very interested to see a minimal example of this bug

The whole API changed in 2 with different function signatures, depreciated methods, new methods etc. so this requires quite a bit of work! Would be happy to look at a...

Would you mind fixing the test?

Good spot, would be happy to review a PR

I remember looking into this at the time, but I can't remember the justification for doing it like this...let me have another look into the mongodb node source and see...

Looking back at the mongo source, I think the reason for making it yield'able was so as to support "strict mode". In this mode it will return an error if...

Confirmed, fancy having a stab at a fix?