James Thompson

Results 441 comments of James Thompson

Note I will be more than happy to contribute a fix for this which would be to stop TryLoadAssembliesWithAttribute from running in a merged application and am testing it in...

So my testing looks good. I effectively exit out of TryLoadAssembliesWithAttributes if I see it is a merged dll. This avoids the exception & the client can resolve connection string.

@oformaniuk & @StefH I see that this has been sitting around for a while, any chance the conflicts could be resolved and then this merge progressed. :)

@oformaniuk I will take a look later today to see if I can push changes to this branch.

@oformaniuk pr #577 has been created to resolve the conflicts and implements the feedback i have above.

@StefH i agree. What I will do tomorrow morning my time is cherry pick the commits on to a new branch from master & then submit that as a fresh...

New PR is #578 which is a nice and clean PR.

After some playing around with Sessions for another project, what i have established is as following: - **Retrieving a Single Session** should be possible by obtaining ISessionStore via DI and...

For me a release package of elsa should not be using preview packages of third parties and hence this dependency should be switched to a release package.