Tsuyoshi Hombashi

Results 42 comments of Tsuyoshi Hombashi

@pavelicii Thank you for your investigation and explanations. One possible approach is to add an option to `AllPairs` class that can choose an algorithm. In this way, users can select...

@pavelicii Thank you for your ideas. In my opinion, breaking changes would be allowed if it is needed My concern is that applying a filter for all possible combinations might...

Hello, @kmaehashi `AllPairs` may not properly work when you try to generate combinations from two parameters. `filter_func` will properly work if you use three or more parameters as following (a...

@kmaehashi Thank you for your comment. That is unexpected behavior. I will check into it.

@kmaehashi Thank you for additional information. This issue might take some time (I had little time to solve the issue for now).

Sorry to keep you waiting. Still work in progress.

Thank you for your report. This issue probably the same cause with #2

Thank you for your feedback. > Implement __hash__ function on DateTimeRange `DateTimeRange` is a mutable class. According to the official document, such a class should not implement `__hash__()`. Therefore, may...

> DateTimeRange is composed of two datetime objects, which are immutable, This is true. However, I believe `DateTimeRange` is a mutable class. Implementation of `__hash__` method for `DateTimeRange` itself is...

I still would prefer to approach that creates an immutable `DateTimeRange` class as a different class. > set_start_datetime and set_end_datetime and any other setter should return another instance, similar to...