Thomas Marshall
Thomas Marshall
I noticed a small difference between MRI and the implementation here. When instantiating the error directly, in MRI the `path` method returns `nil` but with this change in TruffleRuby it...
Is it possible to hand off the running of the tests to the LSP instead of having the VS Code extension do it directly? That way the extension wouldn't need...
Do you consider it misuse to wrap specs manually in a class instead of relying on `register_spec_type` and a top-level `describe`? One example codebase is [Shopify/tapioca](https://github.com/Shopify/tapioca/tree/main/spec) which I believe does...
Yeah that makes sense. I think one reason Tapioca (and other projects using Sorbet) wrap the tests in a class is that Sorbet is doing static type checking so it...
Nice, that looks good. I'll wait until you've finished poking and then I can rebase and deal with the conflict, or feel free to just change my patch directly, whichever...
Nice, I think it looks good. Should I update the PR to include that change?
Awesome, thanks!
I force pushed to add a `T.let` assertion to the constant.
Is there anything else I should do for this PR? No rush, I actually don't need this fix, I just picked it up as a small and simple task to...
The latest version of minitest (5.25.2) now [includes the class name in the spec name](https://github.com/minitest/minitest/pull/1017) which should fix this issue. | Before | After | | - | - |...