Thomas J. Fan
Thomas J. Fan
> Can't we just make a bridge between the scoring parameter u want and the metrics sklearn module, such that it refers to the metric from sklearn module. The [scorers...
In the case of https://github.com/scikit-learn/scikit-learn/issues/28995#issuecomment-2122718356, if we introduce `score(X, y, scoring=None)` and scoring is already set in `GridSearchCV`, then there is a valid default for grid_search.score`. I'm liking the proposal...
Thank you for looking into this! Here are my high level thoughts for implementing a `FlyteRemote` in Rust: - Do not use `flytekit.models`. `flytekit.models` was required when `flyte` was originally...
> The current version has no client code like AdminServiceClient. It's a more unified way to manage proto files in one single place. Alternatively, should I compile FlyteIDL proto files...
I think figuring out the RustPython data exchange and writing a Rust's `FlyteClient` can be two separate task: 1. The Rust `FlyteClient` is a pure rust library that implements and...
> With respect to the Rust coherence rule, be careful when using external crates like prost-types for well-known types such as prost_types::Duration. Thank you for the info! That is good...
> Mind letting me add the above analysis to the design doc? I've invited you as an editor, too. Yup, you can add anything of my comments into your design...
> like in flyteidl and then create the binding layer only in flytekit? This way we will be pure rust in flyteidl that can be imported as a crate? I...
> I see your point, but if users want to use the UV image from a private registry, they must update every image spec I think it is reasonable for...