Thomas J. Fan

Results 251 comments of Thomas J. Fan

I recommend opening an issue in https://github.com/intel/scikit-learn-intelex, because the issue only happens when `sklearnex` patches `scikit-learn`. With that in mind, I am closing this issue because it is not actionable...

Syncing with `main` should help. The linting error was recently fixed in https://github.com/scikit-learn/scikit-learn/pull/24065

> Potentially I could just amend this such that it just points to the relevant pages in the sphinx documentation instead? Thinking about it more, I agree with you that...

I removed the "Breaking Change" label because this preserves the behavior in scikit-learn when SciPy 1.10 is released. In a sense, this PR is fixing something in scikit-learn that would...

As for @lesteve's comment, we can think about backporting this change to 1.1.3 so that `1.1.X` works with SciPy 1.10 with the same behavior as SciPy 1.9. Note, by the...

I think we still have to wait until Cython 3 to actually set `NPY_NO_DEPRECATED_API`. XREF: https://github.com/cython/cython/issues/4805

I like the idea of a `USE_NEWEST_NUMPY_C_API`.

For those who are running into "YD01: No Yields section found", it could be the cv parameter. Update `An iterable yielding (train, test) splits as arrays of indices` to: ```...

@atharvapatil123 Which function were you working on?

> Actually, I just noticed that this is happening for all the functions. As I am quite new to open-source, will you please help me in solving this problem? Remove...