Thomas Hayes

> Hi Thomas, > > I started with an implementation of the battery about two months ago and didn't realize there is already this PR. I will review it in...

@tsicking I have now updated the PR to remove the last commit. I have had the OpenEMS device working with the battery in practice for a couple of months now...

Hi Thomas, Thank you for checking out and inspecting the code. I will tidy up the code and push another commit in a while fixing the checkstyle issues. I will...

More generally, I have encoded all the Pylontech "Alarm" channels as `Level.FAULT`. Given Pylontech's explanation of the difference between "Alarm" and "Protection", these should probably be `Level.WARNING`.

@clehne @tsicking I agree that it is unfortunate that Pylontech named these registers as 'Alarm' when realistically they are warnings. I have changed all the alarm channels to Level.WARNING already...

I have pushed a couple of commits to rename the 'alarm' channels to 'warning' so that they will be more easily understood. I have left the 'Protection' channels as-is. I...

One issue I am observing (related to the low temperature issue) is that I am not sure if the discharge current limits are being applied properly. Currently I have the...

Ok - I will validate with Pylontech about this behaviour just to be sure that the batteries are behaving correctly. Seems strange to me that there would only be limitations...

Hi @tsicking I have reviewed this with Pylontech and this is expected behaviour. The discharge current does not ramp down, due to the physical characteristics of the battery, the discharge...

Hi @tsicking I am not sure how to revert the commit on the PR - I will look again but if you have figured out how to do it that...