Thomas Eizinger

Results 1888 comments of Thomas Eizinger

> Running `docker logs` in CI seems inconvenient Not sure why you say that actually. You can dump all container logs with: ``` docker ps -aq | while read cid;...

Thank you for the detailed comment @t3hmrman ! I am still curious whether the following would also solve the problem: > > My concrete use case - I needed to...

> I think it would be the user's job (i.e. code _above_ `testcontainers-rs`) to do the checking for `CI`, but once that kind of code was installed it would be...

To wrap this up, I'd suggest the following: 1. Always forward a container's stdout and stderr to the parent process Cargo captures stdout and stderr for successful tests, meaning this...

Friendly ping! This would be a nice addition :)

> > Friendly ping! This would be a nice addition :) > > @thomaseizinger does my PR accomplish what you're looking for? If so I'll rebase it. Yes! I am...

> Is there a reason you're not using `futures::future::Either` for that? I guess we could yeah! I'll try and report back.

It doesn't work at the moment because `project` is not exposed publicly. However, I think from the [previous responses](https://github.com/rust-lang/futures-rs/issues/2629), people are okay with adding it so I'll submit a PR...

Another thing I just discovered is that `futures::Either` has a - IMO - very weird implementation of `Future`: ```rust impl Future for Either where A: Future, B: Future, { type...

Would you be up for merging an implementation of the `futures` traits that doesn't try to be clever and simply sets all associated types to `Either`, i.e. `Future::Output`, `Stream::Item`, etc