boringtun icon indicating copy to clipboard operation
boringtun copied to clipboard
verified publisher icon cloudflare

Keeping timers relative to start of tunnel initiation is confusing

Open agrover opened this issue 3 years ago • 5 comments

Keeping timers this way means that for example update_session_timers takes a time_now param that's a Duration instead of an Instant. All entries in Tunn::timers are Durations when many of them are "the time that something happened" and idiomatically I think these would be better expressed as Instants.

agrover avatar Aug 24 '22 18:08 agrover

Agreed.

Noah-Kennedy avatar Aug 25 '22 02:08 Noah-Kennedy

@agrover @Noah-Kennedy Anyone available to review? 😁

crajcan avatar Nov 05 '22 20:11 crajcan

Friendly ping! This would be a nice addition :)

thomaseizinger avatar Jan 24 '24 19:01 thomaseizinger

Friendly ping! This would be a nice addition :)

@thomaseizinger does my PR accomplish what you're looking for? If so I'll rebase it.

crajcan avatar Jan 24 '24 20:01 crajcan

Friendly ping! This would be a nice addition :)

@thomaseizinger does my PR accomplish what you're looking for? If so I'll rebase it.

Yes! I am hoping that we can also move this to be entirely SANS-IO so we have control over the what "now" is :)

See https://github.com/cloudflare/boringtun/issues/391.

thomaseizinger avatar Jan 24 '24 20:01 thomaseizinger