Thomas Eizinger
Thomas Eizinger
The diff on the lockfile seems a bit excessive to me. Can you checkout the one from main and redo the bump to make that smaller? Thanks!
Is the CI error reproducable locally?
> How will a user disable this notification if he/she doesn't wish to update? Wouldn't we need a "ignore this version" button that persists the choice to disk too? Maybe...
> So it won't notify them every day unless they're restarting Firezone every day. I restart my computer every day so I guess Firezone will be restarted too? I imagine...
For all those interested, this (and other things) are now included in our `boringtun` fork as of today: https://github.com/firezone/boringtun/pull/45.
At libp2p, I built a CI check that looks at the PR scope (fix, feat, etc) and checks if the changelog has been modified. If not, it fails unless there...
For reference: - https://github.com/libp2p/rust-libp2p/blob/9a45db3f82b760c93099e66ec77a7a772d1f6cd3/.github/workflows/ci.yml#L91-L105 - https://github.com/libp2p/rust-libp2p/blob/master/scripts/ensure-version-bump-and-changelog.sh
Closing as stale.
From what I can see, this piece of code has already been added like this in https://github.com/tokio-rs/mio/pull/1351 and has even been present in https://github.com/bbqsrc/mio-named-pipes/blame/cdd2dbb0d322bfec9978ce4487c65f5b22c781e3/src/lib.rs#L631-L634 since its inception 9(!) years ago....
I think this will be significantly easier once we have https://github.com/firezone/firezone/issues/4473. The client knows when it is shutting down and can still execute commands.