Thomas Eizinger

Results 1888 comments of Thomas Eizinger

We should also take this opportunity to unify the resolution of SRV and TXT records here. Essentially, what we need on the Gateway is a DNS client that: 1. Automatically...

Related: https://github.com/firezone/firezone/issues/3553. We'd need a way to discover / configure those addresses if we want the gateway to use them to connect to clients.

If it should only be used for egress traffic to resources, then #3553 doesn't matter.

Stripping does interfere with stacktraces reported to Sentry. I discovered that recently and removed all stripping in #7403.

I am not following the async-std development but I'd consider that one too established to remove. Plus, it is optional as you said. I think it would be more fruitful...

> Might it be possible to get rid of the `async-std` (optional) dependency? I'd guess the ecosystem has moved on to `tokio` these days, with the last commit in `async-std`...

> > * Is there any interest having these adapters in this repository in case other people have similar usecases? > > I'm not sure what you mean with these...

Replaced by https://github.com/cloudflare/boringtun/pull/417.

> Hey, thanks for the PR! Really sorry for getting back to this so late, studies have been all-consuming this year. I wonder if we would want to keep smol...

> I would advise removing the lockfile, as it mostly does nothing for libraries, and switch to something like https://crates.io/crates/cargo-minimal-versions to validate the minimum requirements. Having the lockfile ensures deterministic...