Thomas Eizinger
Thomas Eizinger
Any plans on merging this soon?
So when writing something up, I realized that actually utilizing the drop notifier here is a bit pointless :D I'll write it up anyway because I think it is a...
> Do we really need the lookup of the mapped host port for an internal port? > [https://github.com/testcontainers/testcontainers-rs/blob/dev/src/core/docker.rs#L82](https://github.com/testcontainers/testcontainers-rs/blob/dev/src/core/docker.rs?rgh-link-date=2021-01-25T21%3A40%3A02Z#L82) Yes we need that otherwise we don't know what ports the OS...
Thanks for your proposal! I think it will be valuable if the default case (a TCP port mapping) is easily accessible. As such, what do you think about an API...
> > What I am trying to say is: Can we maybe just leave the mapping API as is and simply search for the mapped port in the `PortMapping` response...
I guess we could have rustdoc examples that are tagged with `norun` to avoid spinning up too many containers during testing. Generally, we try to have integration tests for every...
Agreed. I think the best way to extend the current codebase here is to have an optional field in the docker client and produce FQ container names in case they...
> While `--volume` won't get deprecated, `--mount` seems to be the [preferred way](https://docs.docker.com/engine/reference/commandline/run/#add-bind-mounts-or-volumes-using-the---mount-flag). It is funny how the documentation contradicts itself here. From the first sentence of the [volumes documentation](https://docs.docker.com/storage/volumes/):...
From reading the documentation, I get the feeling that a possible solution could be to make testcontainers manage volumes as separate entities the same way we manage containers, i.e. by...
Does this function work for you? https://github.com/testcontainers/testcontainers-rs/blob/dev/src/core/container.rs#L143-L155