Thomas Eizinger

Results 1887 comments of Thomas Eizinger

I don't feel strongly about the feature-flag approach. It just that I couldn't find a different way for enabling (de-)serialization that also works in more complex cases. As already mentioned...

@carllerche @seanmonstar what are your final thoughts on this? It would be good to have a decision here in order to start working on alternative solutions, like an `http_serde` crate,...

I am not sure if I understand 100%. Do you want me to update the PR so that the feature is named `serde1` and then it is good to be...

I renamed the feature, added tests and enabled them on Travis aswell. Let me know if there is more to be done (roundtrip test all of the status codes?)

> With newer versions of Cargo, it's possible to rename the crate in the `Cargo.toml`, like so: > > ``` > serde1 = { package = "serde", .. } >...

Unfortunately, that doesn't work because `serde_derive` seems to expect the crate to be imported under a specific name: `serde`: ![image](https://user-images.githubusercontent.com/5486389/58521919-95202200-8201-11e9-8555-31919e909c21.png)

> I think if you use at least [serde v1.0.90](https://github.com/serde-rs/serde/releases/tag/v1.0.90) it should be possible using to the new `#[serde(crate = "...")]` attribute. Unfortunately, the whole "rename" idea doesn't quite work....

> The rename is problematic. Are you saying we want no renaming at all, i.e. the feature should be named `serde`? Manually implementing `Serialize` and `Deserialize` sounds like a good...

> No, we definitely want the feature to be serde1, no optional serde. So through using the cargo rename feature right? I am not my computer right now but I...

> Bleck, I'd personally opt for us just remove those examples from the docs then. I'll give it a shot and see what the impact is.