Thomas Desrosiers comments

Results 6 comments of


                                            Thomas Desrosiers

Support virtual IPs for services

Hey @DentonGentry One use case I don't see solved by that set of options (please correct me if I'm wrong!) are services who's clients are configured to talk to them...

Why does adding a new commit affect PRs on commits earlier in the stack?

I also have the same issue, from manually bisecting versions I think it looks like this broke between `0.8.5`->`0.9.0`.

Why does adding a new commit affect PRs on commits earlier in the stack?

Okay bisected with: ```bash # rebuild loop rm bin/* for p in ./cmd/*; do echo $p go build -o bin/$(basename $p) $p done mv bin/commithook bin/spr_commit_hook mv bin/reword bin/spr_reword_helper ```...

Why does adding a new commit affect PRs on commits earlier in the stack?

Okay I actually see this as fixed as of https://github.com/ejoffe/spr/commit/6f93850d1f6436aaa8b9c8fd3455d9d4847503e4 so if you're still around @WesleyYue try rebuilding from master and give it another go. Its looking fixed on my...

Why does adding a new commit affect PRs on commits earlier in the stack?

That said HEAD isn't in a release xD So I might still leave this open so its easier for folks to find.

Why does adding a new commit affect PRs on commits earlier in the stack?

Thanks for the release, it looks good here! And no worries about being a bit absent; many thanks for putting together the only stacked PR tool I've found that doesn't...