thomascorthals

RequestBuilders are responsible for setting the Content-Type

1

If we want to support JSON updates alongside XML updates, it no longer makes sense to have the Adapters set a default Content-Type for POSTs. There were already a number...

Support JSON requests for updates

1

As discussed in issue #992 / PR #994, JSON updates are necessary to index single nested child documents. They also open up atomic update functionality for nested documents that isn't...

As suggested by @mkalkbrenner in #899 there are some adjusments we could adopt from search_api_solr.

JSON requests for Update queries

1

This is my first shot at JSON Update requests. I didn't write any integration tests yet, hoping to get some early feedback first. Can be merged without integration tests IMHO...

Solr 9.4 → 9.5 for integration tests

1

Four changes to the tests: * Workaround for [SOLR-17176](https://issues.apache.org/jira/browse/SOLR-17176) that causes test failures against Solr 9.5 * Updated test for [SOLR-6853](https://issues.apache.org/jira/browse/SOLR-6853) workaround to test a fix introduced in Solr 9.4.1...

this.element.find(...).andSelf is not a function

10

[.andSelf()](https://api.jquery.com/andself/) was deprecated in jQuery 1.8 and removed in jQuery 3.0. [.addBack()](https://api.jquery.com/addBack/) should be used instead from jQuery 1.8 onward.

Return type of filter_var() with array argument FILTER_REQUIRE_ARRAY option

1

### Bug report When calling `filter_var()` with an `array` argument and the `FILTER_REQUIRE_ARRAY` option, PHPStan assumes it can return `array|false`. In reality it always returns an array. If every element...

Symfony EventDispatcher 7

1

There's nothing backward incompatible for us in version 7. I've been running it like that for a while in a production environment without issues and the integration tests all pass....

### Bug report [$http_response_header](https://www.php.net/manual/en/reserved.variables.httpresponseheader.php) is deprecated in PHP 8.5.0. PHPStan doesn't report this deprecation. ### Code snippet that reproduces the problem https://phpstan.org/r/8da77505-4474-4aa5-99d9-e29c4776acc5 ### Expected output Deprecation should be reported. ###...

Typed properties

6

A new major version is the perfect opportunity to do some overhaul on the codebase. I've replaced the type hints with actual type declarations on class properties (introduced in PHP...