Thomas Bonnet

Results 37 comments of Thomas Bonnet

> (We should also check other i18n strings amended in that PR, e.g. I think 'unflag' had the same change made and we should make sure we've not missed any...

I adjusted some words and phrases @djuber, like `courriel` to `e-mail` for all french files, edited `guillemet` to `citation`, make more sense for me, but I would like someone to...

## Errors from Travis CI 1) I18n does not have missing keys ```bash Failure/Error: expect(missing_keys).to be_empty, "Missing #{missing_keys.leaves.count} i18n keys\n #{details(missing_keys)}" ``` Missing 20 i18n keys ```bash [{:key=>"fr.helpers.articles_helper.recently_published", :file=>"config/locales/helpers/fr.yml"}, {:key=>"fr.helpers.authentication_helper.email_password",...

> I think I see it - `authentification_helper` should have remained `authentication_helper` (in helpers/fr.yml). That probably explains the majority of the remaining missing keys. > `{:key=>"en.datetime.expires_in.over_x_yars.one", :file=>"config/locales/en.yml"},` > > in...

@aitchiss Ooh yes of course! Edited !

> > We're getting closer with the CI build - I can feel it! > > I'm now seeing just this error: > > ``` > Failures: > 1) I18n...

> @thomasbnt This is a MONUMENTAL effort! Thank you so much! > > Could we resolve the conflicts and continue addressing the feedback in the PR? Let us know if...

> @djuber @thomasbnt It's not a big deal but could you check [this comment of mine](https://github.com/forem/forem/pull/17487#discussion_r872070930) if you don't mind? There appears to be some confusion. Oh hello @yheuhtozr, what...

~~I didn't see your comment 😅~~ @yheuhtozr Oh yeah I see !

Updated this PR with new file `config/locales/views/moderations/fr.yml`. (From this PR https://github.com/forem/forem/pull/18235) I'm not sure about the translation of the word "Tag", if it should stay as such, or translated as...