tcme

Results 172 comments of tcme

Did a test build and merged this into staging-darkmode, here is how it looks with darkmode: ![Screen Shot 2023-03-16 at 10 12 07](https://user-images.githubusercontent.com/546900/225571053-5346fcda-e7b8-4db0-847f-697e559ff51a.png) ![Screen Shot 2023-03-16 at 10 12 14](https://user-images.githubusercontent.com/546900/225571089-0112f93c-8760-41e1-930d-44a6a648564d.png)...

master (d218bc5134e9fdd1495ed36d6fb48679c73bfbaf) File sizes after gzip: 38.96 kB build/static/css/main.8628b67e.css du frontends/web/build/static/media 18216 frontends/web/build/static/media this branch (86360fa50e29ea7f7db66ca68c8c3a2033f29974) File sizes after gzip: 33.27 kB build/static/css/main.69a6916f.css du frontends/web/build/static/media 9312 frontends/web/build/static/media

@benma this is new, vendoring the first npm module, PTAL. planing to squash all commits. with this change, the flag-icons are now taken from our local vendored directory https://github.com/digitalbitbox/bitbox-wallet-app/blob/873d9672e34aa3ea0cb1bee699888b6d9887241c/frontends/web/src/routes/buy/exchange.tsx#L16

flagicons was updated and fixed. I think we still could vendor the prod deps, but will open a different PR for that.

15 problems 🎉 ``` > npm run typescript && eslint --ext .jsx,.js,.ts,.tsx ./src > [email protected] typescript > tsc -p tsconfig.json /opt/go/src/github.com/digitalbitbox/bitbox-wallet-app/frontends/web/src/api/subscribe.ts 45:33 error Invalid type "TEvent" of template literal expression...

when runnign `make webtest` I got the following error two times. But everytime I tried again I couldn't reproduce 🤔 ``` ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Errors ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Vitest caught 1 unhandled error...

Once approved I'll squash everything into 1 commit.

could you update the commit body describing why this change is necessary i.e. I copied this for you, but am not sure if there is another reason: > maintain summary/description/screenshots...

> F-Droid definitely needs a [fastlane structure](https://gitlab.com/-/snippets/1895688) for the metadata like descriptions and screenshots. Should I open a PR for that? Is there anything else that will be needed? that...