Andrew Sliwinski

Results 42 comments of Andrew Sliwinski

It would be ideal to support both, but I'm certainly open to a major version bump that only supports promises.

Good catch. We should modify the API and do a major version bump.

@jbergstroem No problem. PRs welcome.

@markdorison any thoughts on this?

Thanks @andrewcashmore! I'll try to address this soon.

Good question! Using edit distance for matching is a really interesting use case. I'm going to modify your title to make this a little more generic, but this is certainly...

@nsantini I think I would be interested in all three of these features as long as they were added in a way that is optional (as to preserve performance for...

@pdw207 This is still open pending a PR. I'd be happy to review a PR from you if you want to pickup where @nsantini left off.

I think with the work coming in as part of #128 I'd be happy to do a major version change and update the minimum `engine` to Node 8. Yay ES6...

Update: with `5.0.0` we have updated the minimum `engine` to Node 8.0.0. Happy to accept PRs that migrate over to usage of `const`, `let`, arrow functions, and ES6 class syntax....