fastly icon indicating copy to clipboard operation
fastly copied to clipboard

Published 20 hours ago • verified publisher icon thisandagain

Promise support

Open zeke opened this issue 6 years ago • 3 comments

Hello @thisandagain! Long time no see. 👋

This module is handy, but it would be more ergonomic in our new async/await world if it supported Promises. I'd be happy to open a PR for this but want to see first if this module is maintained, and if such a change would be welcomed.

zeke avatar Jul 30 '19 02:07 zeke

Hey @zeke! :wave:

This module is still used in production by our team, but I haven't had much reason to make changes. Happy to accept a PR adding support for promises.

thisandagain avatar Jul 30 '19 21:07 thisandagain

Nice! Question: Would you be open to a new major version (breaking change) that only supports Promises? Or is it important to continue supporting both?

zeke avatar Jul 31 '19 03:07 zeke

It would be ideal to support both, but I'm certainly open to a major version bump that only supports promises.

thisandagain avatar Jul 31 '19 03:07 thisandagain