Andrew Sliwinski

icon indicating a website link http://andrewsliwinski.com icon indicating an email [email protected]

icon company The LEGO Group icon location Denmark icon location Building toys for learning and creativity @LEGO. Past: MIT, Mozilla, DIY.org, and all sorts of other shenanigans.

Results 43 comments of Andrew Sliwinski

Bump target to iOS7, introduce nullability, always async, and separate storage from queue

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

Calling enqueueWithData: when queue is not running can cause duplicate calls to processJob: delegate method

Thanks so much for the detailed issue. I'll dig into this asap.

Calling enqueueWithData: when queue is not running can cause duplicate calls to processJob: delegate method

@ryandotsmith Totally agree... "locking" rows in the data model is a nice / simple way to address this and guarantee some safety and add some flexibility. :+1:

Calling enqueueWithData: when queue is not running can cause duplicate calls to processJob: delegate method

Great feedback. Thanks @dre-hh

Added optional 'runAfter' timestamp to jobs.

Wonderful. Thanks for this @ehlersd . I'll review this as soon as possible.

Would be great to expose the queue size

Agreed! :+1:

Would be great to expose the queue size

A pull request would be most appreciated. > On Oct 31, 2014, at 2:53 AM, Chris Tingley [email protected] wrote: > > I could probably thrash a pull request together, unless...

Ensure that prerelease comparison matches spec

Hi @nrbrook. I haven't been focused on maintaining this module given most of my development is now in Swift these days. That said, I realize I am very behind in...

isValid Check Does Not Comply To Semver Spec

Thanks @jonmchan. I'm happy to accept a PR for this.

Promise support

Hey @zeke! :wave: This module is still used in production by our team, but I haven't had much reason to make changes. Happy to accept a PR adding support for...