Simon Chiang

The context class created in environment.rb raises some warnings due to the @only and @except variables not being initialized. Example: ``` % echo 'gem "rack"' > Gemfile % gem bundle...

Prevent circular symlinks to working directory

1

I've been thinking more about the 'circular symlink' thing and I think the approach is desirable even though the symlink isn't. (regarding http://github.com/wycats/bundler/issues/closed#issue/64) Say you don't do the circular approach:...

Squeeze blank lines by default for -m output

2

A limited, informal survey of the default pager for man indicates that squeezing blank lines is typical. The result is a tidier output. Surveyed: - [Ubuntu](http://manpages.ubuntu.com/manpages/precise/en/man1/man.1.html) pager -s - [OSX](https://developer.apple.com/library/mac/#documentation/darwin/reference/manpages/man1/man.1.html#//apple_ref/doc/man/1/man)...

Periods at the start of a line cause issues for groff. The normal escape sequence for periods (`\.`) causes lines to disappear when they are the first non-whitespace characters, even...

Should use a less common variable in templater

1

Like _attrs_ or similar... otherwise attrs cannot be used as a variable. ``` # Build the template, setting the attributes and filename if specified. # All methods of self will...

That way only a subset of the templates could be funneled through template_files. ``` template_files('subset') do |source, target| m.file(target) {|io| io

By using method missing you open up subtle bugs: ``` m.template_files do |source, target| m.file(target) {|io| io

``` module FilePatch def file(target, options={}) options[:source] ||= begin source_file = Tempfile.new('generate') yield(source_file) if block_given? source_file.close source_file.path end source = options[:source] target = path(target) copy_file = true msg = case...

``` def directory(target, options={}) target = path(target) case when !File.exists?(target) log_relative :missing, target when !File.directory?(target) log_relative 'not a directory', target when target == Dir.pwd when !Root.empty?(target) paths = Dir.glob File.join(target,...

It would be nice to have a set_env method used internally by with_env such that you can use setup/teardown to set the env.