Jérémie Chassaing

Results 40 comments of Jérémie Chassaing

I also tried to keep the password parameter definition without default value, and pass the value as reference in the dynamic parameters like this: ``` { "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#", "contentVersion": "1.0.0.0",...

After a new try, it's working... I had accidentally an invalid schema in the template file... my bad.

There seems to be a official Microsoft preview of those assemblies for net46 and netcoreapp2.2: https://www.nuget.org/packages/Microsoft.SqlServer.DacFx/150.4384.2-preview It probably may help !

The Microsoft.SqlServer.DACFx has been released and is not in preview anymore: https://www.nuget.org/packages/Microsoft.SqlServer.DACFx/150.4573.2

I don't think it's a problem to require dotnet 3.0 or higher for the design time assemblies. Sometime it's touchy to require latest version on runtime, but it's usually far...

Yes but you don't have to load the type provider design time assembly inside Fake, Fake will just launch a dotnet build, right ?

I 've seen the same with Provided types: ``` //File1.fs module MyModule type MyProvidedType = XmlProvider ``` ``` //File2.fs module Usage open MyModule // it is grayed... should not !...

I'm ok to leave GetMessage in the management api. But having an Async version (returning a task) is very important for .Net performance.

I signed the commit 👍

For now, the exception is thrown in PublishAck.Init(): https://github.com/nats-io/nats.net/blob/1e5f0fb6b63a9b9c578613b95ff32e9899fb19e8/src/NATS.Client/JetStream/PublishAck.cs#L35 Avoiding the exception thus require to throw this exception only in some cases.