Thijs

Results 11 comments of Thijs

I like the idea of add and delete (set could just be delete and add, right?), but currently my main issue is adding a static header to the request that...

How about some basic documentation for your errors? Showing me `console.error(err);` in your code examples instead of some proper error handling is useless, and kind of insulting. It's not as...

So has this issue had any progress made on it? I have the same problem and I now have PII in my sentry errors, which I really do not want.

Added pull request to solve this. See https://github.com/brianc/node-postgres/pull/2682

Is there anything (else) I need to do to get this PR applied? Except wait?

Is there something else I need to do to get this merged?

No worries, thanks for taking a look now. It's been so long, I'm not entirely surprised tests fail. I'll take a look at fixing them...

If I run the tests locally on `master` I get an error (so without any of my changes) in `dynamic-password-tests.js`: ``` dynamic-password-tests.js Get password from a sync function FAILED! AssertionError...

Yes, `make test` runs okay for me, but that one does not run the integration tests, which is what is failing. Also on that commit (`adbe86d4a057b942298cab1d19b341c67a94d922`). If you run `make...

Interestingly, in the CI logs I actually see this: ``` ***Testing connection*** Created table person Filling it with people Inserted 26 people ***Testing Pure Javascript*** xargs: warning: options --max-args and...