Thierry FOURNIER comments

Results 6 comments of


                                            Thierry FOURNIER

Support passing arbitrary arguments to "lua-load"

The Lua documentation about "luaL_loadfile" > "lua_load" says : ``` Loads a Lua chunk without running it. If there are no errors, lua_load pushes the compiled chunk as a Lua...

Support passing arbitrary arguments to "lua-load"

By default any variable is global. You must precise "local" to reduce the portability of a variable. It seems the functions follow the same way. The Lua code could be...

Support passing arbitrary arguments to "lua-load"

> Don't you think it's more convenient to use an array of args instead of naming them explicitly ? I don't understand. With this proposition, args are passed with not...

Support passing arbitrary arguments to "lua-load"

I wrote a patch based on the poc above. There is in attachment. The 0001 fix some errors message which contains a jump and should be backported until 1.8 The...

Support passing arbitrary arguments to "lua-load"

Good catch ! Thanks for the fix. I think its strange that the Lua stack was full with 50 args !

Support passing arbitrary arguments to "lua-load"

You probably right. I never thought about this. The HAProxy code contains a lot of `lua_push*` functions called without stack check. In the case of protected function (function declaration prefixed...