Thibaud CANALE

Results 11 comments of Thibaud CANALE

> @thican jfyi protobuf-java is in #26066 Hello @vaukai. Thanks for your notification, I didn’t see your PR before I worked on this. As @Arfrever raised in comment #26066#issuecomment-1166321500, we...

Hi @vaukai, In fact, I have no idea if this is a true dependency, but when I look at the ebuild from your commit, I notice it pulls a dependency...

With branch 3.21, the slot is `0/32` for parent package. Here from the compilation of my up-to-dated ebuild: ``` % command ls -1 /var/tmp/portage/dev-libs/protobuf-21.5/image/usr/lib64/libprotobuf.so* /var/tmp/portage/dev-libs/protobuf-21.5/image/usr/lib64/libprotobuf.so /var/tmp/portage/dev-libs/protobuf-21.5/image/usr/lib64/libprotobuf.so.32 /var/tmp/portage/dev-libs/protobuf-21.5/image/usr/lib64/libprotobuf.so.32.0.5 ``` I don’t...

>> I think it’s better if you can provide the proof where the Java subpackage is API independent. I can’t test right now your package, I will see later. >...

> > > Sorry, tests are not enabled `truth` still missing. > > > > > > Sorry I don’t understand your statement. > > See the test dependencies [here](https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java/3.21.5)...

> > [...] think it's pretty obvious the package is API depend of its parent package. > > The only place where "parent package" is used is https://github.com/gentoo/gentoo/pull/26066/files#diff-a643c80116711a95135940c5c1ac6f417399c643b43cc8f75f21c8617535a7f9R60-R71 I didn’t...

Okay now I understand a bit better the instructions for Java packages, and I see why it was unnecessary to provide instructions for compile and install phases (specially when I...

Hello @vaukai, > @thican One more question: What is the benefit of adding old dev-java/protobuf-java-3.20.1? Is there any consumer of that old version which would fail with the latest version?...

I just rebased then pushed this MR, but I noticed this is pretty much useless. Done anyway, in case of.

EDIT: adds `interdiff`’s version. Hello @teo1978, did you try to use the option `--quiet`? It avoids to add lines `reverted:` inside the output, which might breaks some tools. But anyway,...