Thibaud Colas

@lb- it’s definitely possible with this library, visitor pattern or otherwise. The visitor pattern is just one of the most common ways to structure code working on tree structures, ASTs...

Thank you for the detailed issue report 👌 I have noticed this in the past, but didn’t give it much thought since as @adamghill mentions there were ways to rewrite...

Hey @CAM-Gerlach, thanks for chiming in :) Supporting this simplest case sounds reasonable to me, and is something I will feel comfortable embarking on once I’ve written more tests for...

Hey @bazzadp, thanks for the report. I wouldn’t be surprised if the parser was overly strict in that respect, having had to fix issues with it failing to parse self-closing...

Finally spending time to look into this further, the issue is here: https://github.com/thibaudcolas/curlylint/blob/c144fc6b1bdd3843e9aaaf1b1750ece6febe36d8/curlylint/parse.py#L450 This assumes the tag name on closing tags is directly followed with `>`. I think the fix...

Hey @chris48s, thank you for the detailed report. This makes a lot of sense to me. I’m not too familiar with the implementation of the `indent` rule, but it looks...

Good question – currently the `tests` folder is only used for my manual testing. There are a few templates in there that I’ve gradually started pulling into unit tests, but...

Thank you @360cid, I wouldn’t be surprised if this was indeed the same issue as #28. Currently it’s not ideal that each rule implements its own parsing of the template’s...

Hey @rixx, thank you for the detailed report. No need for the reproducible demo in this case – this is plenty enough of information (and something I’ve noticed myself as...

Well, the mystery thickens! I thought last time I had investigated this that compact was correct and the rest was 0-indexed as initially reported here. I’ll have another look. I...