Wei Zhang
Wei Zhang
Sorry for the late comment. I'm wondering if it could be a glitch in the input. The overriding method cannot have more restricted access than the base one?
> I didn't have ReBindRefsPass in my configuration, I'll try it Hi, I don't think you absolutely need ReBindRefsPass here. It would be great to find out why ResolveRefsPass causes...
Hi, the [aggressive.config](https://github.com/facebook/redex/blob/main/config/aggressive.config) is a good starting point. Please let us know if run into issues with that. We do plan to keep the config information more updated in the...
> If I get a log like the one above, I can delete the pass RemoveEmptyClassesPass right? It seems like it doesn't do much but it could be input dependent....
> How do I see what a pass does? What are the criteria for whether a pass is valuable? We have docs for the passes: https://github.com/facebook/redex/blob/main/docs/passes.md Each pass will collect...
The json error was fixed in https://github.com/facebook/redex/commit/52e44ae995172ccaa2d102cf984cb4248cb3b9d9.
Hi, the provided Redex configs are given as examples. It's not guaranteed that they will work perfectly with any input. As a potential fix, there are other options on the...
Yeah passing in the full name seems to be off. I think you are right on that. However, `kInsertDeobfuscatedNameLinks` is defaulted to be false. So the deobfuscated name lookup is...
Would you be interested in submitting a patch? https://github.com/facebook/redex/blob/main/libredex/IRTypeChecker.cpp#L735
It sounds like in your situation the `deobfuscated_name` is already "obfuscated" by Proguard, is that right? At one point, we were in the same spot. Maybe @ssj933 has more context...