Matt McCormick comments

Results 749 comments of


                                            Matt McCormick

Segmentation fault

We are looking for what is happening at Level 7: ![image](https://github.com/InsightSoftwareConsortium/ITK/assets/25432/633c4117-faf8-4e35-8a4b-adb5ae14a634)

Segmentation fault

Thanks, closer! You will need to step through the code in gdcmPixmapReader (set a breakpoint in QtCreater) to understand what content that is expected is not present.

Segmentation fault

@malaterre any suggestions?

STYLE: Prefer c++11 [[maybe_unused]] attribute over (void)

Thank you for saving this improvement for after v5.4.0 :+1:

STYLE: Prefer c++11 [[maybe_unused]] attribute over (void)

@hjmjohnson v5.4.0 has been tagged -- please merge when you see fit.

Allowing generic output type in `VectorLinearInterpolateImageFunction::EvaluateAtContinuousIndex`

Thank you for the nice investigation and report. Adding the capability to output `double` does seem reasonable.

Allowing generic output type in `VectorLinearInterpolateImageFunction::EvaluateAtContinuousIndex`

Ah, yes, returning `float` make sense, too. A patch is welcome and appreciated. We are happy to provide guidance on implementing the desired functionality in ITK and ANTs. Our [contributing...

STYLE: Revert C++14 workaround when using the constexpr `SupportSize`

@N-Dekker perfect! :pray:

STYLE: Revert C++14 workaround when using the constexpr `SupportSize`

@N-Dekker v5.4.0 has been tagged :rocket: :singer: -- we can merge these drafts when ready.

Update clang-format version

Yes, possibly we just go to pre-commit. Discussed more in https://github.com/InsightSoftwareConsortium/ITK/issues/4235