ITK icon indicating copy to clipboard operation
ITK copied to clipboard

Published 20 hours ago • verified publisher icon InsightSoftwareConsortium

STYLE: Revert C++14 workaround when using the constexpr `SupportSize`

Open N-Dekker opened this issue 10 months ago • 2 comments

C++17 allows using a static constexpr member variable like SupportSize, without being "redeclared". The workaround of copying SupportSize into a local variable is no longer necessary.

Reverts pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2742 commit 27e4815bb816c2cebe3abd0b9aca85afda8101c6 "COMP: Copy BSplineInterpolationWeightFunction::SupportSize within lambda"

N-Dekker avatar Apr 21 '24 17:04 N-Dekker

👍 Please wait until after v5.4.0 to merge.

Thanks Matt. I think this pull request is ready, but I marked it "draft" to prevent getting merged accidentally, before v5.4.0.

N-Dekker avatar Apr 22 '24 08:04 N-Dekker

@N-Dekker perfect! :pray:

thewtex avatar Apr 22 '24 13:04 thewtex

@N-Dekker v5.4.0 has been tagged :rocket: :singer: -- we can merge these drafts when ready.

thewtex avatar May 20 '24 13:05 thewtex