phobos icon indicating copy to clipboard operation
phobos copied to clipboard

find Phobos dependencies on autodecode

Open WalterBright opened this issue 6 years ago • 3 comments
trafficstars

To get rid of autodecode, first we must make Phobos independent of whether autodecoding is on or off. So turn it off and see what breaks.

Fixes should be in separate PRs labelled with [no autodecode]. They should be one of:

  1. use https://dlang.org/phobos/std_utf.html#byChar
  2. use https://dlang.org/phobos/std_utf.html#byDchar
  3. hardcode decoding

WalterBright avatar Aug 13 '19 06:08 WalterBright

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7130"

dlang-bot avatar Aug 13 '19 06:08 dlang-bot

So turn it off and see what breaks.

This should eventually go under a version that we can set defaults on

thewilsonator avatar Aug 13 '19 06:08 thewilsonator

Added [no autodecode] label. Please add this to all PRs that fix autodecoding to work with no autodecoding.

WalterBright avatar Aug 15 '19 21:08 WalterBright