phobos
phobos copied to clipboard
find Phobos dependencies on autodecode
To get rid of autodecode, first we must make Phobos independent of whether autodecoding is on or off. So turn it off and see what breaks.
Fixes should be in separate PRs labelled with [no autodecode]. They should be one of:
- use https://dlang.org/phobos/std_utf.html#byChar
- use https://dlang.org/phobos/std_utf.html#byDchar
- hardcode decoding
Thanks for your pull request, @WalterBright!
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub fetch digger
dub run digger -- build "master + phobos#7130"
So turn it off and see what breaks.
This should eventually go under a version that we can set defaults on
Added [no autodecode] label. Please add this to all PRs that fix autodecoding to work with no autodecoding.