Vahid Al

Results 15 comments of Vahid Al

Hey @RubenRuCh, Sorry, but I had to uninstall Opire. Soul's main contributors weren't too thrilled with its comments, so I had to let it go. I actually really liked the...

Hey @IanMayo, Right now we have `Prettier` (and `eslint`) hooked in `pre-commit` (using `husky` and `lint-staged`, refer to https://github.com/thevahidal/soul/blob/5bbd1a0213892348e621ea73896b288a4f9e755b/package.json#L67-L70), and also it worths mentioning that we're also using `eslint-config-prettier` which...

Yeah, I agree to archive / delete it for now.

That's actually a good idea, though from the beginning of Soul I was really concerned about this endpoint as the power it has is too much.

As we talked earlier it's a good-to-have feature for Soul, and we can add it to our queue.

Yeah, you're completely right, Soul has tests right now but as you mentioned they might fall behind. But to run tests in the pipeline is a must-have and I'll try...

We should have an strict acceptance criteria to enforce tests on newly added features, and also should write tests for the parts that lack any.

Thanks for the link, I'll make it a priority.

This is a really nice thing, though I think that Heroku got rid of the free plans, do you have any alternative free ones in mind?

Hi @faisalsiddique4400, @AbegaM is working on a new PR about how to serve static files over Soul. Check out #208 for instructions.