Cory Fields
Cory Fields
Replaced my commit with @TheCharlatan's artwork above. It doesn't work in the c-i environment because `bitcoin-config.h.in` is missing. I added an `./autogen.sh` to the script but that doesn't help because...
@TheCharlatan Sure, agreed it's better than nothing. Not quite self-contained, but given that a few of us have independently arrived at what the correct diff should be, it's easy to...
> * The `timingsafe_bcmp` impl in the code was previously always picked. Now it may or may not be picked. At least for now, this one should be coming from...
PR title an description updated.
This warning seems legitimate. Looks to me like we should modernize this code rather than ignoring it, no?
> > This warning seems legitimate. Looks to me like we should modernize this code rather than ignoring it, no? > > It is Qt 5 code base. I did...
@epiccurious What specifically are you ACKing here? Have you read the conversation above?
Ping @hebasto @fanquake @TheCharlatan for buildsystem eyes. Ping @sipa for crypto concept ACK/NACK.
Also ping @dergoegge for fuzzer interactions ACK/NACK.
@dergoegge Ah, thanks for the correction. The option does indeed currently pass through to secp, so that bullet-point in my commit message is wrong and I'll update it. It still...