Cory Fields
Cory Fields
@aureleoules Thanks, that's helpful.
Rebased. We'll see what c-i thinks now. Benchmarks should be all good. I think it makes sense for #29408 to go first though.
Rebased after #29408 merge and undrafted.
Updated to split the last commit as suggested by @maflcko . I also replaced `static inline` with just `inline` in places where I had introduced that.
Seems the ctz builtins here can be switched to c++20's `countr_zero` ? See the libc++ impl [here](https://github.com/llvm/llvm-project/blob/main/libcxx/include/__bit/countr.h#L41), for an example of how it maps to builtins.
Removed one more missed instance of `LIBTOOL`.
Ping @maflcko This (or something like it) is a prerequisite for #29404. There doesn't seem to be any sane way to make this a scripted diff or a clang-tidy transform,...
Removed the include from `interfaces/wallet.h` which snuck in because of a comment: ```c++ //! function will be undefined in builds where ENABLE_WALLET is false. ``` That was the only example...
> > Include them manually with the exception of some files in crypto: > > unrelated question: Is there a reason they need to use the flag at all? The...
> There doesn't seem to be any sane way to make this a scripted diff @TheCharlatan saw this and said "hold my beer". Amazing!