Jimmy

@igchor: the following test failed: ``` cachelib/allocator/tests:cache-allocator-test - BaseAllocatorTest/3.AddChainedItemMultithread ``` It failed on this line: https://github.com/facebook/CacheLib/blob/main/cachelib/allocator/tests/BaseAllocatorTest.h#L4522 With the following output: ``` buck-out/dev/gen/aab7ed39/cachelib/allocator/tests/cache-allocator-test#platform010-clang,private-headers/cachelib/allocator/tests/BaseAllocatorTest.h:4522 Expected: (nullptr) != (childItem), actual: (nullptr) vs nullptr...

Hi Igor, > I have just one concern/question regarding this approach. In current implementation, is it possible for multiple threads to mark the same item as moving? Only one thread...

@igchor: cleaning up the slab release logic can be done in a separate PR. I will need to run this change on a shadow setup for some of our production...

@agordon

cc @agordon for advice.

@vitruvvius: thanks for figuring out a fix! Could you send out a PR?

@wenhaocs: Did you resolve this issue?

if we remove cmake from dependency, do we expect users to have installed cmake from a newer source?

@kevinzs2048: do you still see this issue?

Are you seeing consistent test failures with these tests? What are the outputs of the failure (and backtraces)? We do not see 1 - 3 test failures. (4) we do...