Jimmy

Results 42 comments of Jimmy

Huh can you share your full cache config? (Dump the serialized version of CacheAllocatorConfig). Other questions: 1. Are you sending similar load to both caches? (cache operations per sec are...

Btw for negative cache, CacheLib has this thing called compact-cache that is much more space-efficient than regular cache. https://cachelib.org/docs/Cache_Library_User_Guides/compact_cache

@wenhaocs: huh the compiler errors look like u hit some sort of internal bug in the compiler? (On our end, we have internal use-cases specifying NoType so it should work)....

> 1. The floating point exception is caused by char[0] (let alone the Pedantic Warning from compiler). Huh. I guess technically char[0] is illegal. But I expected compiler to handle...

> 4. Seems GlobalCacheStats does not contain the stats of CCache. Yeah that's right. CCache is intended to be used orthogonal to regular cachelib. You can get the stats directly...

> (1) The put latency of ccache is high compared with regular cache Yeah that's right. CCache put involves us re-writing the entire bucket (which contains several items) when evictions...

@mcengija: > folly:SharedMutex build error of has no member named lock_combine Let me try to clarify a bit. This build error is expected since DistributedMutex is one of the few...

@igchor: Hi, I will be reviewing this week. In the meanwhile, could you run the following cachebench tests? These test the consistency of item values that involve chained items. My...

> the only needed fix for correctness is to change the memory order on reads (at least for non-chained items)? Why the relaxed memory order is enough right now? @igchor:...

@igchor: can you take care of the comments and rebase this PR to latest version? I will try importing it again and run through the internal tests.