thepudds

Results 109 comments of thepudds

If there is interest, some details include: 1. Presumably we would keep the API identical? It is fairly minimal: https://pkg.go.dev/internal/diff 2. Would `rogpeppe/go-internal/diff` be a reasonable import path? An alternative...

> Will you also help keep it in sync with upstream? :) 👍

@quasilyte When modules are enabled, the `go` tool enforces that the module name declared in the `module` statement on the first line of the `go.mod` matches the import path used...

Hi @quasilyte, With the change you made in go-critic, do upgrades end up working for you? For example, if I do: ``` cd $(mktemp -d) go mod init tempmod go...

That was a synthetic example intended to show the problem more clearly, but here is closer to a real example: ``` cd $(mktemp -d) go mod init tempmod go get...

FWIW, the new v1.17.0 release of `golangci-lint` seems to fail when doing a `go get -u`: ``` cd $(mktemp -d) go mod init tempmod go get -u github.com/golangci/[email protected] ``` which...

I had posted this to @F21 in slack earlier, but also posting here. It looks like blackfriday is coming in via `github.com/gobuffalo/release`. The `go.mod` for `packr` includes a `require` for:...

So hopefully that answers the question from @dmitshur: > The canonical import path of blackfriday v1 is github.com/russross/blackfriday. Where is gopkg.in/russross/blackfriday.v1 coming from? In general, as far as I understand,...

And sorry for the multiple posts, but as far as I understand it, the module path (as used in the `module` directive in the `go.mod` of a module) is a...

One other tidbit. Note that: * the errors reported at the top of this issue by @F21 complain about `gopkg.in/russross/[email protected]` (note the v1.5.2), vs. * the `go mod graph` output...