thepudds

Results 109 comments of thepudds

In https://github.com/dvyukov/go-fuzz/issues/218#issuecomment-471694791, you had said: > > I am not sure it's Fuzz function responsibility to know about layout of files on disk. > > I agree, although I do...

@dvyukov I think in case someone supplies a `-fuzzdir` argument. In other words, `-fuzzdir` defaults to `pkgpath/testdata/fuzz`, but someone could set it to `-fuzzdir=/tmp/fuzz`, which would result in the corpus...

Alternatively: * an empty `-fuzzdir` could imply `/testdata/fuzz/FuzzFunc/corpus` (so by default, the package's `testdata` directory is used, and there is no redundancy on the package name), vs. * a non-empty...

> Another option is to just -fuzzdir as is and don't append anything. Then it's implied to be user (script, infrastructure) responsibility to pass proper paths in whatever convention they...

Did the approach for `testing.TB` suggested in https://github.com/golang/go/issues/19109#issuecomment-284614737 not work out because of the issue cited a couple of comments back in https://github.com/dvyukov/go-fuzz/issues/218#issuecomment-472671990 about the challenges of where to put...

> I wonder if it's a good idea to instead allow 2/2+ directories with input corpus? For example, if we read inputs from testdata/something/something, but also from -fuzzdir/-workdir if provided....

@dvyukov @josharian I think you are both saying now that there is no real value in using the `testing.TB` interface. I wanted to confirm that is correct? FWIW, I agree...

Some related discussion in https://github.com/golang/go/issues/19109#issuecomment-493241857, including: > Thus, I'd like to propose to start with an interface similar to GetRandomData([]byte) from the beginning of the discussion, which later can be...

This might be too optimistic, but I guess at least personally I'm hoping the #19109 proposal can get into a state where it is is ready to be re-reviewed by...

I took a brief look at this. If you want to print a warning when stdout is a pipe on windows, you could try something like: ```go h, _ :=...