thephoenixofthevoid

Results 17 comments of thephoenixofthevoid

I will try to test with the previous release first. Because if it fails at the previous one, then it's unrelated to the changes in PR.

Doesn't look like the mentioned commit is to blame. I may investigate this issue if you want to. And then report as a comment below. ``` [loopback-next] $ git checkout...

I commented out the whole checking for `Circular dependency` and it worked. I think we should apply the following logic (which is used in inversify): 1. try ... catch for...

``` $ git checkout d75d79d568b19fa632696e032e136e7e0253e85a [Manually copy todo into examples] $ cd examples/todo $ yarn run test // Same error here ``` (yarn run clean && yarn run build is...

Originally taken from inversify: ```typescript export function isCallStackOverflowError(error: Error) { if (error.message === "Maximum call stack size exceeded") { return true; } if (error instanceof RangeError) { return true; }...

Could you please share some more information about your API that you try to upgrade. What was the error message? Does removing the check for circular dependency helps? That is,...

Do you mix components from different releases? Also, I need to check how core versions differ. What is for sure, the change responsible for it happened before #7527. That is...

Well, it seems you are having conflicting versions of context loaded at the same time. Try to update to newer version at the same time for all components

Well, https://loopback.io/doc/en/lb4/Update-generator.html Is that what you are looking for?

@raymondfeng, create a PR that will defer circular dependency error until actual stack overflow ocurrence? Long story short: this case is when the reappearance of same binding down the resolution...