Tom Helmuth

I'm reopening this, since it seems at the least this could use a comment to explain the strange code for future generations, and it wouldn't be a bad idea to...

I'm curious why @Vaguery doesn't just use @lspector's last suggestion of setting `:max-generations` to a Very Large Number? Why have a max generations if you might want to keep going?...

make sure keep HAH data if it is used elsewhere

I'm definitely late to this party (had a crazy week and saw a long thread). But, I like @Vaguery's idea of checking the legitimacy of things at pushing-to-stack time instead...

Oh yay! I misinterpreted you then. Are you aiming to have feature parity with the current interpreter?

It looks like that check was added here: https://github.com/lspector/Clojush/commit/a014db549268d8508561b135409e61ec663b5feb I don't remember exactly why, but it seems like a good idea. My guess is that something Really Bad happened because...

Make it a non-boolean and set it to `:initialization`? Otherwise, I'd go with false.

I'm pretty flexible here. I can't remember why it's there, so there might be a better reason than I'm remembering. Maybe not though!

There are also `exec_do*vector_integer` and similar instructions for the other vector stacks.

Personally, I'd say do it however you like! If you want feedback, a little at a time might be good, but most things "never get done", so if you're going...