Jorge Gallegos

Results 23 comments of Jorge Gallegos

half of this is being handled in #729

There's no mention in the docs about how runme.sh is executed (i.e. fresh session vs inherited env) so I am curious what this will show

@SirGitsalot PTAL, I am not sure how the integration test would work at all for this one, I could just remove the integration test dir altogether

Also not sure how to fix the sanity test issues here... the items pointed out are not secrets, but references to secret manager resources, so `no_log` isn't appropriate... I'll see...

Sanity tests fixed for new module

@SirGitsalot PTAL, this looks worse than it actually is: 1. Remove broken modules and their integration tests 2. Tombstone those modules in meta/ 3. Add the cloudbuild v2 modules (with...

For this collection _usually_ it is @SirGitsalot who adds the fragments in preparation for release, not saying that's the right way but so far how it happens...

Hello @Michael-Burke I see that you have a sort of test case already, would you mind adding to/modifying the integration tests? The test entrypoint is in [tests/integration/targets/gcp_secret_manager/tasks/main.yml](https://github.com/ansible-collections/google.cloud/blob/master/tests/integration/targets/gcp_secret_manager/tasks/main.yml)

hello @Michael-Burke apologies in advance but quick question: are you using AI to write this feature? Asking because we don't have any policy/guidelines for AI assisted contributions (yet) and I...

@Michael-Burke I don't think there is a problem, we just don't have a contribution policy for such cases, and we should clear those up before merging is all. I'll leave...