google.cloud icon indicating copy to clipboard operation
google.cloud copied to clipboard

Cloud Build v2

Open thekad opened this issue 2 months ago • 5 comments

SUMMARY

Adding support for Cloud Build v2 connections and repositories. No integration tests because this would require creating oauth tokens on gitlab/github and then storing them in the CI which is probably a lot more complicated. I tested it with my own personal Github and Gitlab accounts, and it seems to work.

Additionally, I added a small "debug" function to gcp_utils which I am referencing from the code for general tracing

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_cloudbuildv2_connection gcp_cloudbuildv2_repository

thekad avatar Nov 06 '25 23:11 thekad

@SirGitsalot PTAL, I am not sure how the integration test would work at all for this one, I could just remove the integration test dir altogether

thekad avatar Nov 06 '25 23:11 thekad

Also not sure how to fix the sanity test issues here... the items pointed out are not secrets, but references to secret manager resources, so no_log isn't appropriate... I'll see what I can change in the lint config to make these pass

thekad avatar Nov 07 '25 15:11 thekad

Sanity tests fixed for new module

thekad avatar Nov 10 '25 23:11 thekad

@SirGitsalot PTAL, this looks worse than it actually is:

  1. Remove broken modules and their integration tests
  2. Tombstone those modules in meta/
  3. Add the cloudbuild v2 modules (with no integration tests as we lack the capability to create connections vs github/gitlab/bitbucket)
  4. Update the gcp_cloudbuild_trigger modules to support latest version (no integration tests because of above)
  5. Small convenience function to gcp_utils

LMK your thoughts

thekad avatar Nov 21 '25 23:11 thekad

For this collection usually it is @SirGitsalot who adds the fragments in preparation for release, not saying that's the right way but so far how it happens...

thekad avatar Dec 05 '25 16:12 thekad