Jonathan 'theJPster' Pallant
Jonathan 'theJPster' Pallant
I wanted to see how characters outside the BMP are encoded on Windows 11 on a FAT16 filesystem. The file was called `Smiley 😀.txt`. ```text [2024-10-27T11:47:34Z DEBUG embedded_sdmmc::fat::volume] LFN Contents...
Note that worst case, a filename could consist of 255 codepoints, each between `\U{0800}` and `\U{D7FF}`. These would each be encoded as 3 bytes in UTF-8, meaning the worst-case size...
This looks really interesting - thank you for the PR! Did you have a specific SD Host Controller you wanted to implement `Transport` for?
Currently most of the user-facing types inside `mod sdcard` are re-exported at the top-level to make them easier to find. Should we also re-export `sdcard::Transport` and `sdcard::SpiTransport`?
Reading through this, I think a bunch of the implementation detail in the `SpiTransport` struct could be lifted out into the `SdCard` struct, and the `Transport` trait changed to offer:...
I pushed a few comment fixes to better track where things now are.
Are you planning on making Transport implementations outside this crate? I guess we could merge an experimental trait. I see that embassy-stm32 has a working SD Host Controller driver. I...
Is a git dependency pointing at this branch sufficient?
OK. How do you want to mark the trait as 'unstable' then?
Sounds OK to me. I guess the examples will tell us if we broke the API by doing this.