Jonathan 'theJPster' Pallant

Results 500 comments of Jonathan 'theJPster' Pallant

It's a shame to loose `BlockIdx` and `BlockCount` that embedded-sdmmc had, and to go back to raw `u64` values that you can easily get mixed up. I think I'd also...

OK, so I'll accept `u64` as long as we have `BlockCount(u64)` and `BlockIdx(u64)`. The reason for having both those two types is the same as for having `std::time::Instant` and `std::time::Duration`...

Looking good. Please can we put the arguments the other way around, like they were in embedded-sdmmc? Just to reduce the diff. Also - should we require that BlockDevice::Error: Debug?...

Wait, what SPI device requires you to probe for the sector size? This is an abstraction for hard disks, floppy disks, SD Cards and NVMe devices, and all use either...

@MabezDev points out that https://docs.rs/block-device-driver/0.2.0/block_device_driver/trait.BlockDevice.html exists (it's an async version of basically this trait). We should either bring the async version over here, or we should scrap this and send...

OK, here's a proposal. Because some implementations of the BlockDevice trait might want to do DMA (especially ones that use an SDMMC Host Controller rather than an SPI bus), we...

Well, I tried adding alignment but I don't know if I *love* it. The syntax is a bit messy because Rust won't let be create `type Block = ...;` as...

However, I recommend switching to `picotool` because it's faster and doesn't require mounting the disk drive. Binary releases are available from https://github.com/raspberrypi/pico-sdk-tools/releases

It's a shame to loose `BlockIdx` and `BlockCount` and go back to raw `u64` values that you can easily get mixed up.

Technically we assume short names contain valid ISO-8859-1.