Ned Schwartz

I think this is a great plan going forward and I've added it to the v2 tracking issue https://github.com/github/hotkey/issues/65! One quibble I'd make with this API though is around the...

> Having a functional approach where users can change what `processHotkey` and `processExpansion` across multiple install calls leaves issues with how Leafs are processed in the radix trie, and how...

(I updated the code in your description with the changed processor names)

Maybe we could use `"Space"` as a way to distinguish space as a separator of key sequences (`" "`), and the literal space key as a shortcut (`"Space"`). So for...

This actually relates to https://github.com/github/hotkey/issues/54#issuecomment-992997472 where I suggest we match on `event.code` rather than `event.key`. The `event.key` for space is `" "`: the `event.code` is `"Space"`, so making that breaking...

Maybe the shortcut should be in a `kbd` element?

Moving form a convo from another repo: > Based off this [eventToHotkeyString test](https://github.com/github/hotkey/blob/main/test/test.js#L209), it doesn't look like an uppercase alpha character is necessarily expected Hrm that test _is_ simulating the...

For helpful background; in https://github.com/github/hotkey/pull/43 @keithamus states that "on macOS the "Meta+Shift" plane is always lowercase". I just checked and this does appear to be the case This is also...

Notice above that when the `Control+Meta+Shift` are pressed together the result is an upper case `event.key`! 🤔

This is all very complicated. Here are some givens: - I use "logical shortcut" to mean the shortcut string used by the hotkey library: the one returned from `eventToHotkeyString`. -...