Thomas Heigl

Results 155 comments of Thomas Heigl

@marcusdacoregio: Hi and sorry for pinging you directly. I'd be willing to provide a PR for this if I get a preliminary OK on my suggestion. I think the performance...

@rwinch: Would you accept a PR for this?

@marcusdacoregio: Could you please take a look at this PR and #3097? Is this something you would consider merging?

Closing because there are alternative ways to solve this.

That's possible. I only took over Kryo maintenance in 2020 so I have no idea what happened in 2012. Do you need these tags for any reason?

Unfortunately, I don't understand the code well enough to suggest an improvement. Does the complexity stem from Redisson using async methods and the corresponding [LettuceSubscription](https://github.com/spring-projects/spring-data-redis/blob/main/src/main/java/org/springframework/data/redis/connection/lettuce/LettuceSubscription.java#L43) using sync methods for managing...

Could you theoretically do a sync version of `subscribeService.subscribe` and `subscribeService.psubscribe` and always use the sync version like Lettuce?

Looking at `LettuceSubscription` it seems that all subscription operations are synchronous. Why not mimic this in Redisson?

OK, but looking at the check, this currently always returns a `BlockingSubscriber` for Redisson, because `isAsync` is always false. Right? ```java public static boolean isAsync(RedisConnectionFactory connectionFactory) { return (connectionFactory instanceof...

Or maybe you could raise a ticket in spring data redis to better support third party connection factories? The check could use a default method on the interface instead of...