Alexander Mohr

Results 302 comments of Alexander Mohr

yea, we've been internally switching to httpx for some of jobs because aiohttp keeps giving random https payload errors. I'm all for this now

it's easier now with the refactoring botocore has done and we've incorporated

ok going to close as this isn't really an issue with aiobotocore as 1) the performance issue is really an underlying botocore issue and 2) unfortunately we don't have batteries...

sorry haven't had a chance to look into this yet

i tried that test above in the latest aiobotocore and it passes after adding `@pytest.mark.moto`

ok will re-try, it's because right now our test infra doesn't run tests that don't have moto enabled, I'll try it w/o

so I tested the original testcase w/o moto and it passes fine with latest version, shall we close?

btw using the sync stubber is not really correct, as it doesn't return the AioAWSResponse...technically we should have an AioStubber...however unless you need the functionality no biggie

stuff like https://github.com/boto/botocore/blob/develop/botocore/stub.py#L247 should return https://github.com/aio-libs/aiobotocore/blob/88a43098b1194bf759581acc710ad5bdbdd99a96/aiobotocore/awsrequest.py#L5 to mimic aiobotocore responses

could you work with https://github.com/aio-libs/aiobotocore/pull/975 so we get a PR that includes both aspects? thanks!