aiobotocore icon indicating copy to clipboard operation
aiobotocore copied to clipboard

Poetry packaging

Open dazza-codes opened this issue 3 years ago • 8 comments

Fix #833 although it does not use a lambci docker container in the travis-CI matrix.

This PR is a response to difficulty on a couple of other PRs when I can't grapple with pipenv for my dev-env. There might be bits-n-pieces of this PR that are welcome and other bits that are not. I'm open to discussion, testing and compromises. I'm not having much success with pipenv. Even if this PR is not adopted/merged, I will find it useful to work with this branch and rebase on master and manage a parallel set of poetry-deps as needed.

This is an attempt to use poetry packaging for the project and it might be a contentious PR/issue, depending on dev-team preferences for dev-env setups. In using poetry for the past year or so, this PR represents some patterns that are working consistently for me. Hopefully the added files are mostly self-explanatory, please ask any questions to clarify things and take it for a spin on your local to see how it works out.

TODO

  • update CI/CD to use poetry
  • contributions require using python 3.8 now (?)
  • tests might assume there is a default profile available to get credentials (?), lots of failures without it

dazza-codes avatar Nov 03 '20 18:11 dazza-codes

hmm perhaps aioboto should switch to pyproject.toml as well. Sorry really behind in the forward looking PRs, will try to look soon just been super busy since move, or maybe another aioboto admin can chime in =)

thehesiod avatar Nov 03 '20 19:11 thehesiod

This pull request fixes 5 alerts when merging 32bd40b012a7751e46ecf892bf59652d541cfecb into 2a7c7f5a8c7a61daebe484bc5a6f2232607af82c - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Jun 06 '21 18:06 lgtm-com[bot]

This pull request fixes 5 alerts when merging 12d3d0968c536d0d926fec1e8806bcd68b0c0631 into 2a7c7f5a8c7a61daebe484bc5a6f2232607af82c - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Jun 06 '21 19:06 lgtm-com[bot]

This pull request fixes 5 alerts when merging b8e84367ec77462ada0deb5a192ccccfb8e8b27a into 2a7c7f5a8c7a61daebe484bc5a6f2232607af82c - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Jun 06 '21 20:06 lgtm-com[bot]

This pull request fixes 6 alerts when merging b1dc068a36b27b49612dc09acac389d3673d6ff4 into ef96004d1d84111ca7416da8fcca180be27abbc9 - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 2 for Module is imported with 'import' and 'import from'
  • 1 for Missing call to `__init__` during object initialization

lgtm-com[bot] avatar Aug 25 '21 01:08 lgtm-com[bot]

@dazza-codes given that botocore has swapped to https://github.com/boto/botocore/blob/develop/pyproject.toml seems like this now makes even more sense, thoughts?

thehesiod avatar Jul 20 '22 03:07 thehesiod

@dazza-codes I rebased on this PR to fix unit tests and linting in my fork: lafrenierejm/aiobotocore@poetry-packaging. Would you consider resetting this PR to my updated branch? Or would you prefer that I open a separate PR for review?

lafrenierejm avatar Oct 16 '22 20:10 lafrenierejm

could you work with https://github.com/aio-libs/aiobotocore/pull/975 so we get a PR that includes both aspects? thanks!

thehesiod avatar Jul 07 '23 07:07 thehesiod