Jacopo Clark

Results 12 comments of Jacopo Clark

Hey, It would be cool if stack_pivot would also work for x86_64 and not just for x86. Or at least display a message that it has not been implemented for...

Thank you for the very quick reply. I leave this issue open for now in case it helps you to track it. But feel free to close it if you...

same issue here. I had a quick look at the sources and I think the issue is: https://github.com/nextapps-de/flexsearch/blob/65b027ca316ceefd8ea89f472561a0f91179b2f3/src/index.js#L444-L447 when doing a multi-field search on a document flexsearch appears to call...

Ok, finally got around to testing it and this fixes it for me: https://github.com/nextapps-de/flexsearch/blob/65b027ca316ceefd8ea89f472561a0f91179b2f3/src/index.js#L397-L403 This block could to be changed to include e.g.: ```javascript query = query || options["query"]; ```

The source of the issue is L481 in `document.js`.`query` remains `undefined` in the example used by @dfanchon because `options["query"]` is not defined in that case. https://github.com/nextapps-de/flexsearch/blob/65b027ca316ceefd8ea89f472561a0f91179b2f3/src/document.js#L481 ### Fix ### This...

ups, nevermind. my second fix doesn't work as intended because in the second iteration of the loop `query` has already been set and remains the same for all remaining iterations....

@micheljung I had thought about opening a PR but because I didn't know if my fix is good enough I thought explaining what the problem is and what could be...

Update: @ts-thomas just merged the fix into master, so it should be fixed if you're on current master now

@jaymzh any news on this? (bare URLs in code blocks)

@beef9999 This is an open source project where everyone chips in on their free time. If this is an issue you absolutely want to see in GEF than you're always...